[Bug 46470] supersede all NUM_TP_foo with TP_NUM_foo

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=46470

--- Comment #4 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2012-02-29 03:34:25 PST ---
(In reply to comment #3)
> Haven't I already half done this?
> 
> http://cgit.freedesktop.org/~jonny/telepathy-glib/log/?h=moar-deprecations
> 
> I'm not sure if you already reviewed this

Sorry, I must have missed that. Does it have a bug#?

Regardless:

"examples: #ifdef out Call stuff" ++

"c-constants-gen: use TP_NUM_… instead of NUM_TP_…" (which is also this bug):

The branch I prepared for this bug has both sorts of constant on master, so
people can start porting early. I'd planned to delete the NUM_TP_ versions from
next later.

Your patch looks fine for next. I think the ideal thing would be:

- apply my "generate both" (this bug) to master
- split out the parts of your patch that move the uses of these constants
  from NUM_TP_ to TP_NUM_, and apply those to master too
- maybe deprecate NUM_TP_ too
- merge master into next (not at all trivial - I have a branch with a
  monstrously huge merge)
- delete NUM_TP_ on next

but if you can't be bothered with all that, applying your version to next works
too.

"text-channel: move chat state from channel to here" ++ with trivia:

> +   * has finished preparing the feature %TP_CHANNEL_FEATURE_CHAT_STATES.

That should say TP_TEXT_CHANNEL...

"text-channel test: add test for chat state stuff" ++ with optional trivia:

> +  tp_proxy_prepare_async (test->channel, features,
> +      proxy_prepare_cb, test);
> +
> +  g_main_loop_run (test->mainloop);
> +  g_assert_no_error (test->error);

In new code I'd prefer tp_tests_proxy_run_until_prepared(), which does all this
in one line

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.