[Bug 46513] Make Jingle code less Telepathic

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Feb 29 13:30:29 CET 2012


https://bugs.freedesktop.org/show_bug.cgi?id=46513

--- Comment #2 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2012-02-29 04:30:29 PST ---
> @@ -2374,14 +2361,14 @@ session_terminated_cb (GabbleJingleSession *session,
>   TpGroupMixin *mixin = TP_GROUP_MIXIN (channel);
>   guint terminator;
>   JingleState state;
> - TpHandle peer;
> + TpHandle peer = gabble_jingle_session_get_peer_handle (priv->session);
>   TpIntSet *set;
>
>   DEBUG ("called");
>
> + peer = gabble_jingle_session_get_peer_handle (priv->session);

Duplicate call to gabble_jingle_session_get_peer_handle() (in "MediaChannel:
use gabble_jingle_session_get_peer_handle()", d884caf42e3)

Everything else up to and including that commit looks good. There might be a
million patches but at least they're easy to review :-)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list