[Bug 45564] use TpBaseChannel more

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=45564

Jonny Lamb <jonny.lamb at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #5 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2012-02-29 12:49:44 PST ---
(In reply to comment #2)
> MUC ++ with or without fixing these trivia:
> 
> > + g_object_get (base_conn, "self", &(priv->self), NULL);
> 
> Pre-existing nit: I'd have preferred one property-pair per line, but whatever.
> 
> > + g_object_get (G_OBJECT (conn), "contact-manager",
> > &contact_manager, NULL);
> 
> Likewise here

Fixed these.

(In reply to comment #4)
> RoomList ++, so, all ++ with optional trivia in Comment #2.
> 
> If you wanted to do the Tube channels too, as you did for Gabble in Bug #46502,
> I wouldn't say no.

Some other day.

Merged, thanks for the review!

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.