[Bug 44326] Make gabble cross-compile with mingw32

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=44326

Jonny Lamb <jonny.lamb at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

--- Comment #2 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2012-01-02 03:54:25 UTC ---
+#ifdef G_OS_WIN32
+       DEBUG ("fully received %Iu bytes of data", str->len);
+#else
        DEBUG ("fully received %zu bytes of data", str->len);
+#endif

+#ifdef G_OS_WIN32
+       DEBUG ("Append data to buffer of %s (%Iu bytes)", from, str->len);
+#else
        DEBUG ("Append data to buffer of %s (%zu bytes)", from, str->len);
+#endif

Can %zu not just be replaced with G_GSIZE_FORMAT?

http://developer.gnome.org/glib/2.30/glib-Miscellaneous-Macros.html#G-GSIZE-FORMAT:CAPS

+#ifndef ERROR
 #define ERROR(format, ...) \

Where is ERROR being defined already? I'm not sure we want that to be
conditional.

+#ifdef G_OS_WIN32
+   strftime (date_str, sizeof (date_str), "%y-%m-%dT%H:%M:%SZ", tm);
+#else
    strftime (date_str, sizeof (date_str), "%FT%H:%M:%SZ", tm);
+#endif

Shouldn't that be %Y instead of %y?

+if WINDOWS
+ AM_CFLAGS += -D_WIN32_WINNT=0x0501
+endif

Can you just add a comment above this documenting what's going on please? It's
a bit cryptic.

Then just a few English nits:

+#------------------------------------------------------------
+# Detect Operating system based on --host
+#------------------------------------------------------------

$host, not --host, surely?

+# following flags is requied to make getnameinfo work

s/flags/flag/ and s/requied/required/

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.