[Bug 44825] test-stream-tube unit test fails since glib 2.31.x

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=44825

--- Comment #1 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2012-01-19 06:19:58 PST ---
Review of
http://cgit.collabora.com/git/user/xclaesse/telepathy-glib.git/commit/?h=fix-ut&id=a8aaf76e128ee3a0dd393f7c8e4734f53fd27c41

You removed the FIXME in tests/lib/stream-tube-chan.c but didn't actually
change the code.

tp_unix_connection_receive_credentials_with_byte_async() shouldn't take the
byte as an arg. Instead it should be returned by the _finish() function.

The _async() methods are not documented and added to the doc. "make check"
won't pass.

client_socket_connected: remove the // comment

service_incoming_cb() should wait for the byte being received before
processing.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.