[Bug 49372] deprecate tp_account/connection/channel_new

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=49372

--- Comment #12 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2012-07-02 05:27:04 PDT ---
Comment on attachment 61957
  --> https://bugs.freedesktop.org/attachment.cgi?id=61957
Examples: stop using tp_account/connection/channel_new()

Review of attachment 61957:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=49372&attachment=61957)
-----------------------------------------------------------------

::: examples/client/extended-client.c
@@ +211,5 @@
>  
>    if (die_if (error, "RequestConnection()"))
>      return;
>  
>    /* FIXME: there should be convenience API for this */

Is this still applicable? Probably not, because real applications (except MC)
shouldn't be using RequestConnection anyway.

@@ +212,5 @@
>    if (die_if (error, "RequestConnection()"))
>      return;
>  
>    /* FIXME: there should be convenience API for this */
> +  factory = tp_simple_client_factory_new (NULL);

Isn't this leaked?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.