[Bug 49372] deprecate tp_account/connection/channel_new

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=49372

--- Comment #14 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2012-07-02 05:32:41 PDT ---
Comment on attachment 61959
  --> https://bugs.freedesktop.org/attachment.cgi?id=61959
Deprecate tp_account_new(), tp_connection_new() and tp_*_channel_new()

Review of attachment 61959:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=49372&attachment=61959)
-----------------------------------------------------------------

::: telepathy-glib/automatic-proxy-factory.c
@@ +115,5 @@
>      G_IMPLEMENT_INTERFACE (TP_TYPE_CLIENT_CHANNEL_FACTORY,
>        client_proxy_factory_iface_init))
>  
> +/* Deprecated module can use deprecated APIs */
> +G_GNUC_BEGIN_IGNORE_DEPRECATIONS

Is this module really deprecated? I thought this one was the non-deprecated
version?

I would prefer these guards to be around smaller blocks of code (i.e. the
actual constructor).

Even better would be to have:

/* internal, called by the proxy factory */
TpStreamTubeChannel *_tp_stream_tube_channel_new (...);

/* extern, deprecated, to be deleted in next */
TpStreamTubeChannel *tp_stream_tube_channel_new (...);

TpStreamTubeChannel *
tp_stream_tube_channel_new (...)
{
  _tp_stream_tube_channel_new (...);
}

since we're presumably going to want _tp_stream_tube_channel_new in next
anyway.

::: telepathy-glib/client-channel-factory.c
@@ +75,5 @@
>  G_DEFINE_INTERFACE(TpClientChannelFactory, tp_client_channel_factory,
>      G_TYPE_OBJECT)
>  
> +/* Deprecated module can use deprecated APIs */
> +G_GNUC_BEGIN_IGNORE_DEPRECATIONS

See above, although at least this one is actually deprecated...

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.