[Bug 51441] [next] replace TpBase*Class::interfaces by TpBase*Class::get_interfaces

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=51441

Jonny Lamb <jonny.lamb at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://cgit.freedesktop.org
                   |                            |/~jonny/telepathy-glib/log/
                   |                            |?h=51441-get-interfaces
           Keywords|                            |patch

--- Comment #1 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2012-07-05 07:15:20 UTC ---
Okay I worked on this in master. Once merged, I'll remove all the old stuff in
next.

(In reply to comment #0)
> TpBaseChannel, TpBaseCallContent and TpBaseCallStream use that system, but not
> TpBaseConnection,

Done.

> TpBaseConnectionManager,

Done.

> TpBaseRoomConfig and

This doesn't actually need this? I did fix a comment referring to
TpBaseChannel.interfaces though.

> TpBaseProtocol.

This already has a get_interfaces() which returns a newly-allocated GStrv (why,
I wonder?) This makes is harder to chain-up. Do you think another
get_interfaces_array (which uses a GPtrArray) should be added for master, then
renamed in next?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.