[Bug 33410] Do on-disk avatar cache in CM

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Jul 11 14:15:41 CEST 2012


https://bugs.freedesktop.org/show_bug.cgi?id=33410

--- Comment #28 from Xavier Claessens <xclaesse at gmail.com> 2012-07-11 12:15:41 UTC ---
(In reply to comment #24)
> (Only commenting on the API right now, not the English.)
> I think we should just say the CM SHOULD cache avatars somewhere in
> XDG_CACHE_HOME/telepathy/avatars/*cm*, and that for each avatar for which the
> MIME type is known, it MUST store that in the file with the same name + ".mime"
> (or equivalently, the same file: URI + ".mime").

Good idea, changed the spec like that.

> + <tp:struct name="Contact_Avatar">
> 
> Do we need the MIME type on D-Bus at all? I don't think we do. If the CM is
> required to store the MIME type (where known) alongside the image, then we can
> just have plain avatar URIs in the D-Bus API, and any client that consumes them
> will read the image from that URI, and the MIME type from that URI + ".mime",
> successively.

Tbh, the MIME is ~useless. So I'm happy to remove it from DBus with that URI
suffix trick. Done.

> I don't like the name "contact avatar" for something that is only a reference
> to the avatar (specifically, the file URI). I'd prefer Avatar_URI or even
> Cache_URI (and without the MIME type, it'd become a tp:simple-type).

It's now a simple-type "s" and renamed to Avatar_URI

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list