[Bug 21796] get_contact_statuses should not be allowed to fail

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=21796

--- Comment #2 from Will Thompson <will.thompson at collabora.co.uk> 2012-07-11 14:35:30 PDT ---
Comment on attachment 64110
  --> https://bugs.freedesktop.org/attachment.cgi?id=64110
TpPresenceMixinGetContactStatusesFunc: remove the GError argument

Review of attachment 64110:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=21796&attachment=64110)
-----------------------------------------------------------------

::: telepathy-glib/presence-mixin.c
@@ +976,2 @@
>  
> +  g_hash_table_iter_init (&iter, contact_statuses);

tp-glib should still check whether contact_statuses is NULL, rather than just
crashing if the CM returns NULL. (Maybe it should fill in "unknown" for all
handles if the CM returns NULL? Or just leave it out of the attribute
dictionary.)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.