[Bug 31668] break C API to drop deprecated stuff

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=31668

--- Comment #21 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2012-07-12 14:05:23 UTC ---
Xavier merged master into next and removed some deprecations here:

http://cgit.collabora.com/git/user/xclaesse/telepathy-glib.git/log/?h=next-remove-deprecated

Some comments:

02050c89a381c9e9e:

You could use tp_asv_new (NULL, NULL) instead of g_hash_table_new_full (blah
blah blah).

cdb02889684c082:

+ test->sms_channel = TP_TEXT_CHANNEL (tp_client_factory_ensure_channel (
+     factory, test->connection, chan_path, props, &test->error));
  g_assert_no_error (test->error);
+ g_assert (TP_IS_TEXT_CHANNEL (test->channel));

The second assertion should be test->sms_channel, no? It's also redundant
(there's another too) as the TP_TEXT_CHANNEL cast will typecheck, no?

Otherwise, seems good.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.