[Bug 52053] RemoveContacts() don't properly reject subscription request

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=52053

--- Comment #1 from Robert McQueen <robert.mcqueen at collabora.co.uk> 2012-07-13 16:07:58 PDT ---
To my untrained eyes, it looks like this code in gabble_roster_handle_remove is
responsible:

...
  /* If the contact is really stored on the server, deleting their roster item
   * is sufficient. If they're not, we might have some state resulting from
   * a publish request or remote removal or something. */
  if (item->subscription == GABBLE_ROSTER_SUBSCRIPTION_REMOVE)
    {
      /* These will clear a status of REMOVED_REMOTELY or ASK */
      roster_item_set_publish (item, TP_SUBSCRIPTION_STATE_NO, NULL);
...

I think this _set_publish needs to be outside of the _REMOVE case - a contact
who is _NONE or _TO on the roster could still be asking us for publishing
permission.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.