[Bug 52206] deal with google changing caps node name

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=52206

--- Comment #2 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2012-07-17 18:11:38 PDT ---
Let's try that again.

(In reply to comment #0)
> If we've got recognisable google features in ext='…' then just use them
> regardless of what the node is. Here's a branch.

I'm kinda suspicious about this because it violates the relevant XEP - but on
the other hand, it's clearly what Google actually do (otherwise their various
clients wouldn't interop with each other), so it's fine for anything that
interoperates with Google. Also, 'ext' is a deprecated part of the XEP.

I vaguely wonder whether to do this but only for URLs matching
\.(android|google)\.com/ but life is too short, and if we did, they'll probably
start advertising google.co.uk caps just to spite us :-)

> + /* We also cache the ext='' bundles Gabble advertises: older Gabbles

There is no also, this is now the beginning of the function.

> + gabble_presence_set_capabilities (
> + presence, resource, cap_set, NULL, serial);

Er, if you have ext='voice-v1 video-v1' doesn't this end up setting voice-v1,
then overwriting it with video-v1 so you lose the voice-v1 cap?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.