[Bug 32612] Remove Tubes code

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=32612

Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|telepathy-bugs at lists.freede |jonny.lamb at collabora.co.uk
                   |sktop.org                   |

--- Comment #5 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2012-07-18 10:59:26 PDT ---
I'm reviewing patch-by-patch, so it's possible that some of my review comments
are fixed in a later patch.

"private-tubes-factory: create only Tube channels for requests"

+gabble_private_tubes_factory_lookup (GabblePrivateTubesFactory *self,
...
+ g_object_get (tube,
+ "channel-type", &channel_type,
+ "handle", &channel_handle,
+ "service", &channel_service,
+ NULL);
+
+ if (!tp_strdiff (type, channel_type)
+ && handle == channel_handle
+ && !tp_strdiff (service, channel_service))
+ match = FALSE;

Isn't this backwards? It should set match = TRUE if everything matches.

(This essentially gives all requests for a private tube "create" semantics, but
it looks as though pre-existing bugs in the _requestotron implementation gave
them those semantics anyway...)

> +new_channel_from_request (GabblePrivateTubesFactory *self,

I think this deserves Returns: (transfer none) in a pseudo-doc-comment.

+ g_hash_table_insert (channels, channel, request_tokens);
+ tp_channel_manager_emit_new_channels (self, channels);
+
+ g_hash_table_unref (channels);

The GHashTable is no longer needed. Just use
tp_channel_manager_emit_new_channel (self, channel, request_tokens).

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.