[Bug 32612] Remove Tubes code

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=32612

--- Comment #10 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2012-07-18 11:39:29 PDT ---
(In reply to comment #5)
> I'm reviewing patch-by-patch, so it's possible that some of my review comments
> are fixed in a later patch.

I think I've now reviewed enough (up to "private-tubes-factory: make
extract_tube_information public") that you could fix some of the review
comments and merge the 1-1 tube bits, if you want.

Overall, the 1-1 tube stuff looks good, and I agree we should finally make this
happen. My review comments are pretty minor and should be easy to fix.

Having a single "namespace" for tube IDs even between multiple peers is a
design flaw, presumably a pre-existing one, but we can fix that separately (and
make sure that if/when we do stream tubes via Jingle, we don't inherit the
design flaw). I suggest opening a separate bug for this.

> Er, this function allows Alice to close tubes between us and Bob, if she can
> guess or brute-force the tube ID. Pre-existing bug?

This is also not a merge blocker if it's a pre-existing bug, but if you don't
fix it, please open a separate bug for it.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.