[Bug 32612] Remove Tubes code

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=32612

--- Comment #14 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2012-07-18 13:01:52 PDT ---
"muc-channel: disappear from the bus when not requested"

+ DEBUG ("making MUC channel reappear!");
+ tp_base_channel_reopened_with_requested (base, FALSE, sender);
+ g_signal_emit (chan, signals[APPEARED], 0);

I can't help thinking that if the appeared signal is necessary in Gabble, then
telepathy-glib is not being sufficiently helpful for Bug #48210.

Couldn't muc_channel_closed_cb handle the reappearance if
(channel.is_respawning()) like I suggested in Bug #48210 Comment #6? (Yes, I
realise this is pretty strange.)

Alternatively, TpExportableChannel or TpBaseChannel could grow a reappeared
signal or something?

+ gboolean needed_not_wanted,

If you reverse the sense of this flag, and call it export_text or something,
then things might be a bit more natural:

+ if (gabble_muc_channel_get_autoclose (*ret))
+ gabble_muc_channel_set_autoclose (*ret, needed_not_wanted);

could become

    if (export_text)
      gabble_muc_channel_set_autoclose (FALSE);

which I think is maybe clearer.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.