[Bug 52206] deal with google changing caps node name

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=52206

Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|                            |review+

--- Comment #5 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2012-07-18 16:16:50 PDT ---
(In reply to comment #4)
> > > + gabble_presence_set_capabilities (
> > > + presence, resource, cap_set, NULL, serial);
> > 
> > Er, if you have ext='voice-v1 video-v1' doesn't this end up setting voice-v1,
> > then overwriting it with video-v1 so you lose the voice-v1 cap?
> 
> No. I've updated the test to make it explicit that I'm testing this.

After several false starts I realised this works because set_capabilities
doesn't just mean "discard your caps, here are the new ones": it aggregates all
calls to set_capabilities with the same "serial". I can't help thinking this
ought to be simpler (asynchronously work out what the new set of caps-bundle
URIs means, accumulate them in a set of capability URIs, then push them all
into the presence in one go at the end?), but it's clearly not a merge blocker,
so, ship it.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.