[Bug 49473] Set TCP_NODELAY in tests

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Jul 23 19:36:47 CEST 2012


https://bugs.freedesktop.org/show_bug.cgi?id=49473

--- Comment #1 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2012-07-23 10:36:47 PDT ---
I think this needs some #ifdefs, unless you've verified that it can be
cross-compiled to Windows (I recommend mingw-w64, as seen in Debian unstable)
and/or looked it up on MSDN.

Either throw in some configure checks for setsockopt, IPPROTO_TCP and
TCP_NODELAY, or approximate it by #ifdef G_OS_UNIX?

Other than that it seems good. We like fast tests.

(In reply to comment #0)
> You could argue that this should only be enabled when it's not a release build.

I'd rather not have release builds test themselves differently. Perhaps you
could make it controllable by an environment variable or its own --enable
thing, and have Gabble use the default (i.e. not NODELAY) during distcheck?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list