[Bug 52231] Storage plugins should be able to create new accounts

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=52231

--- Comment #13 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2012-07-23 11:14:07 PDT ---
Comment on attachment 64434
  --> https://bugs.freedesktop.org/attachment.cgi?id=64434
CreateAccount: make possible to select a desired storage

Review of attachment 64434:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=52231&attachment=64434)
-----------------------------------------------------------------

r+ with a change to a comment.

::: mission-control-plugins/account-storage.c
@@ +332,5 @@
>    iface->get_restrictions = method;
>  }
>  
> +void
> +mcp_account_storage_iface_implement_create (

Not actually needed, but that's not a blocker.

(One day we should deprecate these in favour of writing directly into the
GInterface vtable, since we have to allow that for bindability anyway - not
that this API is bindable in any case.)

::: src/mcd-account-manager-default.c
@@ +529,5 @@
> +{
> +  gchar *unique_name;
> +
> +  /* See comment in plugin-account.c::_storage_create_account() for an
> +   * explaination of how this works */

s/for an explaination of how this works/before changing this implementation,
it's more subtle than it looks/

(Also, that's not how you spell explanation.)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.