[Bug 52441] Race when preparing blocked contacts

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Jul 24 14:26:00 CEST 2012


https://bugs.freedesktop.org/show_bug.cgi?id=52441

Xavier Claessens <xclaesse at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |xclaesse at gmail.com

--- Comment #1 from Xavier Claessens <xclaesse at gmail.com> 2012-07-24 12:26:00 UTC ---
The problem here is RequestBlockedContacts returns before
TP_CONNECTION_FEATURE_CONNECTED is prepared. This is probably because the CM is
actually connected but TpProxy does more extra stuff before marking the
CONNECTED feature.

Possible fix for this is to make TP_CONNECTION_FEATURE_CONTACT_BLOCKING feature
depend on TP_CONNECTION_FEATURE_CONNECTED, so preparing BLOCKING will wait
until connection goes online. This has a side effect that if you naïvely add
that feature on the factory, TpAccount will never signal the connection until
it's done connecting...

Another solution (and that's what CONTACT_LIST feature does) is to just
immediately return success if the connection is not yet connected, then emit
"blocked-contacts-changed" signal with the initial set once the connection is
connected.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the telepathy-bugs mailing list