[Bug 32612] Remove Tubes code

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=32612

--- Comment #16 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2012-07-24 16:06:18 PDT ---
Okay I think I fixed everything you said, and opened bug #52448 about this:

(In reply to comment #6)
> Not a merge blocker and presumably not your fault, but these semantics are
> crazy. We should have a separate tube ID "namespace" per peer, and store tubes
> in the hash table by (handle, id) tuples or something.
[...]
> Er, this function allows Alice to close tubes between us and Bob, if she can
> guess or brute-force the tube ID. Pre-existing bug?

I pushed fixes as new commits at the top of the branch for ease of review,
apart from the one where I needed to change the commit message.

╻  ╻╻┏ ┏━╸   ╺┳╸┏━┓╺┳╸┏━┓╻  ╻  ╻ ╻
┃  ┃┣┻┓┣╸     ┃ ┃ ┃ ┃ ┣━┫┃  ┃  ┗┳┛
┗━╸╹╹ ╹┗━╸    ╹ ┗━┛ ╹ ╹ ╹┗━╸┗━╸ ╹ 

┏━┓╻ ╻┏━╸┏━┓┏━┓┏┳┓┏━╸   ╻  ┏━┓╻  
┣━┫┃╻┃┣╸ ┗━┓┃ ┃┃┃┃┣╸    ┃  ┃ ┃┃  
╹ ╹┗┻┛┗━╸┗━┛┗━┛╹ ╹┗━╸   ┗━╸┗━┛┗━╸

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.