[Bug 52049] Update telepathy-gabble-tests to show pass/fail tests status

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Jul 30 13:03:35 CEST 2012


https://bugs.freedesktop.org/show_bug.cgi?id=52049

--- Comment #7 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2012-07-30 11:03:35 UTC ---
Comment on attachment 64784
  --> https://bugs.freedesktop.org/attachment.cgi?id=64784
New telepathy gabble tests patch

Review of attachment 64784:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=52049&attachment=64784)
-----------------------------------------------------------------

::: tests/twisted/run-test.sh.in
@@ +24,5 @@
>      @PYTHON@ @gabbletestsdir@/twisted/$i
> +    e=$?
> +    case "$e" in
> +        (0)
> +            echo "Result  $i: pass"

Is there any reason not to use "PASS: $i", "SKIP: $i", "FAIL: $i" like Automake
does? (Or "FAIL: $i ($e)" would be OK if you'd prefer to have the status
included.)

I would much prefer the pass/fail/skip to be at the beginning of the line like
that: "^FAIL" is an easier thing to grep for than "^Result.*fail", and much
less likely to appear during normal operation as a result of a debug message or
something. If you're going to screen-scrape test results like this, make them
as unambiguous as possible.

(Consider a debug message that says "*** Tp-DEBUG: Result of badgering: failed
to match mushroom to snake", for instance. You don't want to catch that as a
false-negative failed test by grepping for "Result.*fail".)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list