[Bug 33410] Do on-disk avatar cache in CM

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=33410

--- Comment #15 from Xavier Claessens <xclaesse at gmail.com> 2012-06-07 08:52:01 PDT ---
(In reply to comment #13)
> I have just been looking through your new avatar spec:
> 
>  * there are a few grammatical problems here and there, shall I just branch
> your
>    spec branch and make my changes?

Yes please.

>  * why is there a AvatarsNeedRequest signal? (that name sounds bad too, btw)
> Why
>    doesn't the CM just request the avatar and save it in the cache immediately?

The CM request the avatar only if a client is interested by it, that's why
AvatarsNeedRequest is emitted so clients interested will call RequestAvatars in
return.

tbh I wouldn't mind letting the CM just request all avatars for which it has a
token but not found in cache, that would simplify lots of things. In practice I
think there is always a client that will ask to request the avatars anyway.

CM could be smart a delay the request when in power-saving mode though, but I
think gabble already put the vcard request on hold until we leave power saving
mode, right?

But I think Simon won't agree...

>  * probably s/Mission Control/the account manager/ but feel free to say 'no'.
> :-)

Makes sense, yes :)

>  * you should make loads more links, to other specs and XEPs, etc.

Right

>  * I wonder if we should make AvatarUpdated plural?
> 
> Other than these, the idea seems reasonable. I'll look at your tp-glib branch
> now.

Right

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.