[Bug 50834] tp_account_get_connection_manager() and _get_protocol() naming is wrong

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=50834

--- Comment #3 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2012-06-08 03:24:17 UTC ---
(In reply to comment #2)
> Here is branch for master:
[...
> It deprecate wrong names and add the correct names.

That approach is perfect, IMO.

The branch looks good, except for this:

> Note that this introduce a small behaviour change: "connection-manager" and
> "protocol" properties are not CONSTRUCT_ONLY anymore. This is because we can't
> have 2 CONSTRUCT properties setting the same value, otherwise the default-value
> would override the value set on the other property. This shouldn't affect any
> application since that API was added in previous release, and
> tp_account_request_new() should be used anyway.

If you set the property twice (which is now "officially" allowed - the metadata
says you can set it at any time, now!), the set_property() implementation
asserts. That seems bad.

I would be inclined to omit this patch from master altogether, and just do a
straight rename in next. As you say, applications will probably use new()
anyway, so this shouldn't result in much/any actual porting between 0.x and
1.0.

> Deprecated APIs will then
> be removed in next.

Ideal.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.