[Bug 50834] tp_account_get_connection_manager() and _get_protocol() naming is wrong

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=50834

--- Comment #5 from Xavier Claessens <xclaesse at gmail.com> 2012-06-09 01:26:19 PDT ---
(In reply to comment #3)
> (In reply to comment #2)
> > Note that this introduce a small behaviour change: "connection-manager" and
> > "protocol" properties are not CONSTRUCT_ONLY anymore. This is because we can't
> > have 2 CONSTRUCT properties setting the same value, otherwise the default-value
> > would override the value set on the other property. This shouldn't affect any
> > application since that API was added in previous release, and
> > tp_account_request_new() should be used anyway.
> 
> If you set the property twice (which is now "officially" allowed - the metadata
> says you can set it at any time, now!), the set_property() implementation
> asserts. That seems bad.

I don't understand what you mean. "connection-manager" is now read-only and
"cm-name" is construct-only, so you can set it only once. The only issue is if
an app does g_object_new (TP_TYPE_ACCOUNT_REQUEST, "connection-manager", foo,
NULL); it will now fail. But only empathy uses it and any app is using
tp_account_request_new() anyway. So really the issue is purely theoric.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.