[Bug 51033] Add support for see-other-host

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=51033

--- Comment #5 from Xavier Claessens <xclaesse at gmail.com> 2012-06-19 08:46:41 PDT ---
(In reply to comment #4)
> + p = g_strstr_len (host_and_port, -1, ":");
> + if (p != NULL)
> +   p = g_strstr_len (p + 1, -1, ":");
> + if (p != NULL)
> +   uri_format = "%s://[%s]";
> 
> It took me a little while to work out what you were actually checking for here.
> Could you just add a small comment to point out you're looking for two ':'
> chars please?

Added /* if host_and_port contains 2 ':' it must be an ipv6 */

> - /* properties: */
> - GIOStream *stream;
> -
> 
> Why are you removing this? It looks completely unrelated to the rest of the
> patch. If it's unused feel free to remove it, but please split your patches.

It's unused, pushed that trivia to master already :)

> I don't exactly understand what you are doing in the test but tbh if things
> still test properly and stuff passes and your test case is being executed then
> that's fine by me. :-)

It though me a while to understand how those unit tests works. The idea of my
change is to be able to run multiple servers, so the first will do a
see-other-host error and tell to connect the the next one.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.