[Bug 51033] Add support for see-other-host

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Jun 19 18:25:07 CEST 2012


https://bugs.freedesktop.org/show_bug.cgi?id=51033

--- Comment #9 from Xavier Claessens <xclaesse at gmail.com> 2012-06-19 09:25:07 PDT ---
(In reply to comment #8)
> Regarding your gabble branch:
> 
> Personally I think a nicer way than having both
> 
>      GabbleServerTLSChannel *channel
>      GList *completed_channels;
> 
> in your private structure, you could just have a GQueue *channels and peek the
> head when you mean priv->channel, no? I guess that would make referencing the
> GAsyncResult with channel harder. What do you think?

I think there are a lot of priv->channel access in that code, modifying them
all to g_queue_peek_head() is boring :p

IMO it's nice to have all the current operations stuff in the priv struct, then
have a list for stuff from the past.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list