[Bug 51522] New: conn_requests_requestotron_validate_handle should use tp_ensure_handle_async()

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=51522

             Bug #: 51522
           Summary: conn_requests_requestotron_validate_handle should use
                    tp_ensure_handle_async()
    Classification: Unclassified
           Product: Telepathy
           Version: git master
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: major
          Priority: medium
         Component: tp-glib
        AssignedTo: telepathy-bugs at lists.freedesktop.org
        ReportedBy: will.thompson at collabora.co.uk
         QAContact: telepathy-bugs at lists.freedesktop.org


The latest release of tp-glib allows dynamic handle repos to normalize
identifiers asynchronously. (Upsetting that this is necessary.)

conn_requests_requestotron_validate_handle(), as used by the implementations of
CreateChannel and EnsureChannel, transforms TargetID properties provided in
requests into handles for the benefit of the CM. It does so using
tp_handle_ensure(), not tp_handle_ensure_async(), and hence is now broken. (I'm
setting major severity because I think this is a pretty big deal: through a
totally valid user input, you can now end up with two handles where you should
have one.

Relatedly, TpChannelManagerRequestFunc contains the following documentation:

> Changed in version 0.15.5: Previously the TargetID property was guaranteed to be missing from request_properties. Now it is always present, whether it was in the original channel request or not.

I think it should be pointed out that the TargetID property may not match the
result of tp_handle_inspect(request_properties[TargetHandle]) due to
normalization. This has always been the case—in fact, that was the point of
passing through the TargetID, to allow CMs to process stuff (like dial strings)
that gets stripped out in normalization—but it would be good to explicitly
document this.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.