[Bug 35598] Implement Call channels

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Mar 5 19:02:29 CET 2012


https://bugs.freedesktop.org/show_bug.cgi?id=35598

--- Comment #2 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2012-03-05 10:02:29 PST ---
(In reply to comment #1)
> Also, needs this branch of tp-glib, also needs review
> 
> http://cgit.collabora.com/git/user/tester/telepathy-glib.git/log/?h=call1-misc

"BaseMediaCallStream: Make it possible to set the Content at construct time"
contains this change, which doesn't seem to fit:

> + if (!tp_base_call_channel_is_accepted (TP_BASE_CALL_CHANNEL (channel)))
> + goto done;

Shouldn't that be under a separate commit title?

The branch looks OK in principle, and the first two commits are clearly right.
I don't think I understand Call well enough to review the rest; perhaps Sjoerd
could have a look?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.



More information about the telepathy-bugs mailing list