[Bug 45842] deprecate call_when_ready in master, delete it from 1.0

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=45842

--- Comment #20 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2012-03-06 02:44:25 PST ---
(In reply to comment #18)
> >    unsigned getting_names:1;
> > +  unsigned had_weak_object:1;
> 
> Are we really still using this instead of gboolean in new code?

I was going for "if there's already a bitfield extend it, if not, add a
gboolean".

> Okay so this now makes sense: it'll only call the callback if the weak object
> is still around. Would it be possible to get a comment to explain this a bit
> more though please?

      /* If we never had a weak object anyway, call the callback.
       * If we had a weak object when we started, only call the callback
       * if it hasn't died yet. */

I regret introducing the weak_object parameter, and look forward to the
glorious GIO future, with async results, cancellables where we really really
need them, and "shut up and use TpWeakRef as your user_data" for the few cases
where the weak_object semantics are actually useful.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.