[Bug 14540] Names interface - Aliasing replacement with separate nickname, local alias etc.

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=14540

--- Comment #18 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2012-03-07 04:31:55 PST ---
Comment on attachment 56334
  --> https://bugs.freedesktop.org/attachment.cgi?id=56334
proposed patch

Review of attachment 56334:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=14540&attachment=56334)
-----------------------------------------------------------------

Shouldn't we deprecated Aliasing as well?

::: spec/Connection_Interface_Names.xml
@@ +60,5 @@
> +        display in an address book or list of contacts if no local alias
> +        or nickname is available.</p>
> +    </tp:docstring>
> +
> +    <method name="GetNicknames" tp:name-for-bindings="Get_Nicknames">

Agreed, let's drop it.

@@ +172,5 @@
> +        <p>This property MAY be set on a newly-created connection while it is
> +          still in the Disconnected or Connecting state. If this is done, the
> +          Connection must store the given nickname temporarily, until
> +          connecting succeeds or fails, and apply it if the connection attempt
> +          is successful.</p>

Cool; that solves the Idle case.

@@ +177,5 @@
> +
> +        <p>On protocols where nicknames do not persist between connections
> +          (such as <code>local-xmpp</code>), the connection manager SHOULD
> +          support
> +          <code>org.freedesktop.Telepathy.Connection.Interface.Names.DRAFT.Nickname</code>

Names1.Nickname

@@ +199,5 @@
> +
> +    <tp:contact-attribute name="nickname" type="s">
> +      <tp:docstring xmlns="http://www.w3.org/1999/xhtml">
> +        <p>The same string that would be returned by
> +          <tp:member-ref>GetNicknames</tp:member-ref>.

Should be updated if we drop GetNicknames()

@@ +280,5 @@
> +      </tp:docstring>
> +
> +      <arg name="Contact" type="u" tp:type="Contact_Handle" direction="in">
> +        <tp:docstring>
> +          The contact.

I guess we can't do SetLocalAlias(self_handle) right? May be good to say it to
be clear.

@@ +310,5 @@
> +      <tp:docstring xmlns="http://www.w3.org/1999/xhtml">
> +        <p>If this attribute on a contact is present in the result of
> +          GetContactAttributes, its value is a protocol-specific abbreviated or
> +          formatted version of their self-assigned unique identifier, which may
> +          be more appropriate to display in a user interface.</p>

1) Wouldn't them use the nickname in our account-free Idle glory future?
2) I would ignore this for now; we can always add it later if we really need
it.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.