[Bug 43826] avoid downloading the roster at every connection

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=43826

--- Comment #13 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2012-03-08 06:54:00 PST ---
Nearly there, but some minor stuff that's probably worth appending to the
branch rather than squashing in:

It's worth saying in the doc-comment that download-at-connection doesn't change
anything in TpBaseContactsList's behaviour, and that implementations should
check it when they become connected and in their Download method, and behave
accordingly.

> + g_return_val_if_fail (cls->download_async != NULL, FALSE);
> +
> + return cls->download_finish (self, result, error);

Surely this should check download_finish, not download_async?

Life would be easier for CM authors if you provided
tp_base_contact_list_get_download_at_connection() with the obvious
implementation (looking in self->priv). Then:

> +gabble_roster_get_download_at_connection (TpBaseContactList *base)

... you could just call tp_base_contact_list_get_download_at_connection()
instead.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.