[Bug 46417] Gabble shouldn't install an unversioned library to ${libdir}

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=46417

--- Comment #18 from Olli Salli <olli.salli at collabora.co.uk> 2012-03-08 11:49:52 PST ---
(In reply to comment #17)
> Olli, Jonny: could you review this please? I consider it to be a blocker for
> Gabble 0.16: it breaks Gabble with Ubuntu's default compiler options, and in
> any case we shouldn't have a stable branch that installs an unversioned
> library.
> 
> The options are:
> 
> * Attachment #57521 [details], Attachment #57517 [details], Attachment #57518 [details], Attachment #57519 [details]:
>   turn Wocky into a private shared library (whose name is specific to the
>   version of the project it's embedded in), turn gabble-plugins from an
>   unversioned to a versioned shared library. Helps to keep our Windows/Android
>   builds working, by making our Unix build similar.
> 

Yeah, this is the most sensible option in the long run. We have the buildbot to
catch broken windows builds - but it's better if it already breaks the Linux
developer's build so they notice it right away.

I've reviewed these patches; the build system changes look OK. Siraj is testing
them now with the Ytstenut plugin with his Windows build env and will report
here how it fared in a minute. The Android buildbot tells us if we happen to
break android with this, but that shouldn't happen if both Windows and Linux
builds work OK.

++ for merging if Siraj doesn't notice any problems.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.