[Bug 30422] Provide GVariant-based access to all a{sv} things

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri Mar 9 12:37:34 CET 2012


https://bugs.freedesktop.org/show_bug.cgi?id=30422

--- Comment #14 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2012-03-09 03:37:34 PST ---
(In reply to comment #12)
> ::: tests/dbus/account.c
> @@ +268,5 @@
> > +  if (!tp_strdiff (data, "vardict"))
> > +    {
> > +      tp_account_update_parameters_vardict_async (test->account,
> > +          g_variant_new_parsed ("{ 'set': <%s> }", "value"), unset,
> > +          tp_tests_result_ready_cb, &test->result);
> 
> doesn't this leak the new GVariant?

I believe it does not, because g_variant_new() and friends are just that
clever. (It returns a floating reference, and I made
tp_account_update_parameters_vardict_async consume floating references).

I'll valgrind it to make sure this isn't leaking, though.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.



More information about the telepathy-bugs mailing list