[Bug 47054] Make mission-control quit gracefully

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=47054

--- Comment #1 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2012-03-13 07:30:11 PDT ---
Looks fine to me but here's some bikeshedding:

+static void
+sigusr1_cb (int sig)
+{
+  mcd_service_stop (mcd);
 }

This doesn't seem to be the same indentation as the rest of the file?

+ g_object_unref (mcd);

use g_clear_object here if you want.

Simon is claiming that "using POSIX signals like that isn't safe
unfortunately". Over to you, Simon.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.