[Bug 45716] salut plugin api needs to be split out and refactored similar to the changes done to gabble

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Mar 14 15:48:24 CET 2012


https://bugs.freedesktop.org/show_bug.cgi?id=45716

Olli Salli <olli.salli at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |ASSIGNED
         AssignedTo|siraj.razick at collabora.co.u |alvaro.soliverez at collabora.
                   |k                           |co.uk
                URL|                            |http://cgit.collabora.com/g
                   |                            |it/user/asoliver/telepathy-
                   |                            |salut/log/?h=plugin-api-fix
           Keywords|                            |patch

--- Comment #14 from Olli Salli <olli.salli at collabora.co.uk> 2012-03-14 07:48:24 PDT ---
-      if (gabble_capability_set_has (contact->caps, node))
-        send_stanza_to_contact (porter, WOCKY_CONTACT (contact), stanza);
-    }

+      //if (gabble_capability_set_has (contact->caps, node))
+        send_stanza_to_contact (porter, WOCKY_CONTACT (contact), stanza);
+    }

This behavioral change seems totally unjustified.

Simon: Agreed - I'm keen on reviewing the critical patches for that as I did
for Gabble. But let's sort out which symbols should be in the plugin lib and
which not first please.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.



More information about the telepathy-bugs mailing list