[Bug 31729] use TpBaseContactList in Salut

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=31729

Olli Salli <olli.salli at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
  Status Whiteboard|                            |review+
         Resolution|                            |FIXED
           Keywords|                            |patch

--- Comment #9 from Olli Salli <olli.salli at collabora.co.uk> 2012-03-15 12:54:08 PDT ---
(In reply to comment #8)
> (In reply to comment #7)
> > Umm...
> > 
> > http://cgit.freedesktop.org/telepathy/telepathy-salut/tree/src/connection.c#n724
> > 
> > doesn't include TP_CONNECTION_INTERFACE_CONTACT_LIST, so nothing will actually
> > use the ContactList implementation enabled here. This is evident by running the
> > tp-glib contact list example client, which requires this interface:
> > 
> > http://paste.debian.net/159801/
> > 
> > We'll try adding the CONTACT_LIST interface to the announced ones - expect a
> > report in how that fared shortly. That'd mean completely unexercised code works
> > out of the box though so I'm not really holding my breath for that, but it's a
> > start.
> 
> I was able to get it working with the following one line patch
> 
> http://cgit.collabora.com/git/user/siraj/telepathy-salut.git/commit/?h=contact-list-fix&id=b2523f75fda1d6620f03a39329fa8945ce4f379c

Woo!

Merged.

Against some heavy odds, I suppose this is OK again.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.