[Bug 45716] salut plugin api needs to be split out and refactored similar to the changes done to gabble

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=45716

Jonny Lamb <jonny.lamb at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW

--- Comment #18 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2012-03-16 09:17:31 PDT ---
Ouch! This having to create dummy interfaces just for plugins because of
Windows is really crap. I didn't mind so much for Connection because it's so
central anyway, but now are we really having to do all these other interfaces
for the same reason?

+GabbleCapabilitySet *salut_plugin_contact_get_caps (
+    SalutPluginContact *plugin_contact);

So this is the reason we've got this new SalutPluginContact interface? I assume
this is because the salut_send_ll_pep_event() function needs it? If we move
salut_send_ll_pep_event into Wocky itself this won't be necessary, right? After
all, we already have SalutContact implementing a Wocky capability interface.

 typedef void (*SalutPluginInitializeImpl) (
     SalutPlugin *plugin,
-    TpBaseConnectionManager *connection_manager);
+    TpBaseConnectionManager *connection_manager,
+    SalutCreateProtocolImpl callback);

@callback seems an odd name for said argument.

So say we have another function that we want to access in a plugin but can't
link to it as it's in the core library, or something, how are we going to
extend this? I find this "protocol create function" as an initialize function
argument really ugly and hard to extend on. I think even a struct with these
functions plus some padding would be better as it would be equally as ugly but
would allow for expanding later, no?

Yes, looking at this branch again, we should move salut_send_ll_pep_event()
into Wocky. Looking at the code seems to suggest there's nothing missing in
Wocky, or am I missing something?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.