[Bug 47540] Remove deprecated method g_thread_init

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Mar 20 12:04:00 CET 2012


https://bugs.freedesktop.org/show_bug.cgi?id=47540

Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|                            |review+ with better commit
                   |                            |message

--- Comment #1 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2012-03-20 04:04:00 PDT ---
g_thread_init() is still needed in GLib 2.30 and older, but since GLib 2.24,
g_type_init() implies g_thread_init (NULL). Salut already calls g_type_init(),
and depends on GLib 2.24, so it doesn't need to initialize threads explicitly.

If that wasn't true, this change wouldn't be safe. It's pretty subtle, so
please amend the commit message to justify why it's OK (e.g. copy the previous
paragraph sentence). After that, this is OK to commit.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list