[Bug 43826] avoid downloading the roster at every connection

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=43826

Alban Crequy <alban.crequy at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|http://cgit.collabora.com/g |http://cgit.collabora.com/g
                   |it/user/alban/telepathy-gli |it/user/alban/telepathy-gli
                   |b.git/log/?h=roster4        |b.git/log/?h=roster5

--- Comment #14 from Alban Crequy <alban.crequy at collabora.co.uk> 2012-03-20 12:02:51 PDT ---
Updated in branch roster5.

(In reply to comment #13)
> Nearly there, but some minor stuff that's probably worth appending to the
> branch rather than squashing in:
> 
> It's worth saying in the doc-comment that download-at-connection doesn't change
> anything in TpBaseContactsList's behaviour, and that implementations should
> check it when they become connected and in their Download method, and behave
> accordingly.

Done.

> > + g_return_val_if_fail (cls->download_async != NULL, FALSE);
> > +
> > + return cls->download_finish (self, result, error);
> 
> Surely this should check download_finish, not download_async?

Yes, fixed.

> Life would be easier for CM authors if you provided
> tp_base_contact_list_get_download_at_connection() with the obvious
> implementation (looking in self->priv). Then:
> 
> > +gabble_roster_get_download_at_connection (TpBaseContactList *base)
> 
> ... you could just call tp_base_contact_list_get_download_at_connection()
> instead.

Done.

For the record: TpBaseConnection->create_channel_managers() is called before
the connection's parameters being filled by
TpBaseProtocolClass->new_connection(). So GabbleRoster does not have the
correct value of "download-at-connection" at creation. It is updated later by
gabble_connection_set_property(PROP_DOWNLOAD_AT_CONNECTION). I added a comment
there, as we said on IRC.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.