[Bug 47647] New: Tp-qt fails to remove temp avatar file

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=47647

             Bug #: 47647
           Summary: Tp-qt fails to remove temp avatar file
    Classification: Unclassified
           Product: Telepathy
           Version: git master
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: tp-qt
        AssignedTo: telepathy-bugs at lists.freedesktop.org
        ReportedBy: martin.klapetek at gmail.com
         QAContact: telepathy-bugs at lists.freedesktop.org


Currently I have over 206 000 avatar files in
~/.cache/telepathy/avatars/gabble/jabber, mostly duplicate files (same md5)
with the same name and different suffix (see examples in the log below). Seems
like a tp-qt bug (QTemporaryFile?), maybe even in combination with our apparmor
bug [1].

[1] -
https://bugs.launchpad.net/ubuntu/+source/telepathy-mission-control-5/+bug/939126

Attached is relevant IRC conversation

<andrunko> sjoerd, mck182 tp-qt and tp-glib saves the user avatars in the cache
dir using the avatar token as basis for the filename. Once the token changes it
should retrieve a new avatar and save it also. We use the same algorithm to
generate the filename, so avatars saved by tp-qt/glib are interchangeable. Old
avatars are never cleared from the cache, so it may be your issue, but even so,
it seems like a lots of avatars you have there. But note that
<andrunko>  for each avatar there is an accompanying mimetype file saved as
$avatar_filename.mime
<sjoerd> andrunko: i know how it works, but that seems a lot of avatars still
<sjoerd> especially if there are duplicates
<sjoerd> as those should have the same token
<andrunko> yeah, it could be a bug somewhere, we would need to debug it
<mck182> let me know if I can provide any info
<sjoerd> mck182: well if you could see if there are avatars in there with the
same md5sum that would be interesting
<sjoerd> and ofcourse which servers do you use?
<mck182> gtalk and jabber.org
<mck182> well and a local set up jabber server, prosody
<mck182> but I use that one very occasionaly and for testing stuff only
<mck182> it doesn't even have avatars
-*- mck182 tries to get md5
<mck182> sjoerd andrunko: yes, they all have the same md5
<sjoerd> mck182: so is it one avatar you have *loads* of times or several where
that happens
<sjoerd> and can you give us some example filenames for those
<mck182> sjoerd: part of ls -l -- http://paste.kde.org/444032/
<mck182> I can't actually check how much files are the same etc as operating
with such folder is close to impossible ;)
<mck182> (dolphin hangs completely, ls takes ages to start..)
<sjoerd> -rw------- 1 mck182 500  1818 Mar 13 22:58
f44b207f27561b88e29cb28f825da3aca222676a.yY5899
<sjoerd> -rw------- 1 mck182 500  1818 Feb 27 23:09
f44b207f27561b88e29cb28f825da3aca222676a.Z10848
<andrunko> mck182, sjoerd  hmm it seems like some issue with temporary files
not being properly renamed
<sjoerd> -rw------- 1 mck182 500  1818 Feb 23 12:37
f44b207f27561b88e29cb28f825da3aca222676a.Z11905
<sjoerd> andrunko: exactly what i was going to say
<sjoerd> for some reason it's re-retrieving an avatar it already has and
failing to remove the temporary file if it couldn't rename it i guess
<andrunko> yeah, seems so, xclaesse wrote that part
<andrunko> xclaesse, any idea why is this happening? did you have any similar
issue?
<andrunko> the code seems to be correct
<andrunko> in ContactManager::onAvatarRetrieved
<mck182> sjoerd andrunko: might this be related to the apparmor bug we've been
experiencing with the dconf folder?
<sjoerd> this seems to me more like a tp-qt bug, which *may* be triggered by
apparmor though

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.