[Bug 46484] Add high-level Call bindings

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=46484

--- Comment #14 from George Kiagiadakis <kiagiadakis.george at gmail.com> 2012-03-21 08:28:03 PDT ---
(In reply to comment #13)
> CallChannel is parsing immutable props on construction, but if the channel is
> constructed directly without passing immutable props (in which case it should
> still work), some accessors will be broken, such as initialTransportType(). So
> please, add a proper FeatureCore (not just an alias for Channel::FeatureCore)
> that will check if some immutable prop is missing and if so, retrieve them via
> dbus. Check Channel::Private::introspectMainProperties for reference.

I had the code like this in the beggining, but then thought that if immutable
props are passed in the constructor, it doesn't need to do the extra dbus
round-trip. This constructor argument seems a bit confusing... Anyway, I
reverted the commit and updated it.

> diff --git a/TelepathyQt/Farstream/TelepathyQtFarstream.pc.in
> b/TelepathyQt/Farstream/TelepathyQtFarstream.pc.in
> {QT_MIN_VERSION}, QtDBus < ${QT_MAX_VERSION}, telepathy-glib >= 0.17.5,
> telepathy-farstream >= 0.2.0, TelepathyQt${QT_VERSION_MAJOR} =
> ${PACKAGE_VERSION}
> Please use macros for tp-glib/farstream versions. I noted also that we have
> hardcoded version in TpFarsight.pc.in, it would be good if you could also
> update it.
> The same happens in the uninstalled versions (btw, do we really need them when
> using cmake?). Tbh I guess we could just remove the uninstalled versions as
> this in theory should be used by libtool only.

I don't really know. I've never seen uninstalled .pc files in use. The truth is
that no cmake project uses them, but then again most cmake projects don't
install pkgconfig files anyway.

> Apart from those, excellent work, feel free to merge once the above issues are
> addressed.

Sorry, as I said in irc, I don't have permissions to merge...

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.