[Bug 46484] Add high-level Call bindings

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Mar 21 18:07:08 CET 2012


https://bugs.freedesktop.org/show_bug.cgi?id=46484

--- Comment #17 from Andre Moreira Magalhaes <andrunko at gmail.com> 2012-03-21 10:07:08 PDT ---
(In reply to comment #14)
> (In reply to comment #13)
> > CallChannel is parsing immutable props on construction, but if the channel is
> > constructed directly without passing immutable props (in which case it should
> > still work), some accessors will be broken, such as initialTransportType(). So
> > please, add a proper FeatureCore (not just an alias for Channel::FeatureCore)
> > that will check if some immutable prop is missing and if so, retrieve them via
> > dbus. Check Channel::Private::introspectMainProperties for reference.
> 
> I had the code like this in the beggining, but then thought that if immutable
> props are passed in the constructor, it doesn't need to do the extra dbus
> round-trip. This constructor argument seems a bit confusing... Anyway, I
> reverted the commit and updated it.
Sorry if I wasn't clear here. What I want you to do is to parse the immutable
props on construction and only if there is something missing call GetAll. Your
introspectCore should check if all props were already passed on construction
and if so, just set FeatureCore as ready, if not request the props as you did.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list