[Bug 47723] Add libffi to configure

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri Mar 23 12:45:48 CET 2012


https://bugs.freedesktop.org/show_bug.cgi?id=47723

--- Comment #4 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2012-03-23 04:45:48 PDT ---
This change looks fine, but I'd prefer the commit message to say that this is
only for Android, and the way you've broken the line makes it rather weird in
git tools (have a look at how it looks in gitweb!).

Here's how I'd phrase it without hitting the 80ish character limit for the
first line:

    On Android, use pkg-config --static

    This makes it output the complete dependency chain for each
    library, e.g. libffi for GObject. This is necessary because Android
    toolchains don't follow shared library interdependencies like
    normal GNU toolchains.

(Consider this change pre-reviewed for other Telepathy projects that have an
Android.mk, too - it should work the same.)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list