[Bug 47767] tp_call_content_media_description_append_codec() should be properly documented

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Mar 26 09:31:51 CEST 2012


https://bugs.freedesktop.org/show_bug.cgi?id=47767

--- Comment #2 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2012-03-26 00:31:51 PDT ---
Comment on attachment 58951
  --> https://bugs.freedesktop.org/attachment.cgi?id=58951
CallContentMediaDescription: Add missing documentation

Review of attachment 58951:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=47767&attachment=58951)
-----------------------------------------------------------------

::: telepathy-glib/call-content-media-description.c
@@ +729,2 @@
>   *
> + * Add an SSRC to the list of SSRCs that a contact will send from

Trailing '.' missing. A small explanation of what a SSRC is and how it would be
used may be useful for newbies like me.

@@ +768,5 @@
> + * @name: The name of the codec.
> + * @clock_rate: The clock rate of the codec.
> + * @channels: Number of channels of the codec if applicable, otherwise 0.
> + * @updated: %TRUE if this codec was updated since the last Media Description
> + * @parameters: a #GHashTable of string->string containing optional parameters

This arg should be annotated to make gi happy.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list