[Bug 47928] New: TpContact complains incorrectly about missing interfaces

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=47928

             Bug #: 47928
           Summary: TpContact complains incorrectly about missing
                    interfaces
    Classification: Unclassified
           Product: Telepathy
           Version: git master
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: tp-glib
        AssignedTo: telepathy-bugs at lists.freedesktop.org
        ReportedBy: jonny.lamb at collabora.co.uk
         QAContact: telepathy-bugs at lists.freedesktop.org


TpContact has this:

  if (wanted & CONTACT_FEATURE_FLAG_PRESENCE)
    {
      boxed = tp_asv_get_boxed (asv,
          TP_TOKEN_CONNECTION_INTERFACE_SIMPLE_PRESENCE_PRESENCE,
          TP_STRUCT_TYPE_SIMPLE_PRESENCE);

      if (boxed == NULL)
        WARNING ("%s supposedly implements Contacts and SimplePresence, "
            "but omitted the mandatory "
            TP_TOKEN_CONNECTION_INTERFACE_SIMPLE_PRESENCE_PRESENCE
            " attribute",
            tp_proxy_get_object_path (connection));
      else
        contact_maybe_set_simple_presence (contact, boxed);
    }

So if the contact asks for the presence feature, TpContact is allowed to
complain that the connection claims to support Contacts & SimplePresence but
actually doesn't, even if the connection makes no such claim.

This is happening with rakia, and Empathy/Folks is trying to create TpContacts
with a blanket set of features for all CMs, which I think is a reasonable thing
to do.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.