[Bug 43828] avoid downloading the roster at every connection

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=43828

--- Comment #9 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2012-03-27 09:31:16 PDT ---
> + DEBUG ("don't request the roster because the property"
> + "ContactList.DownloadAtConnection is FALSE");

you're missing a space somewhere in this string (after 'property' or before
'ContactList').

Okay so I looked at the test and was like "whaaa? surely you can easily do this
in a much better way without duplicating so much code?!" Turns out the exact
answer (which I'm sure you already know) is no. I still don't like so much code
duplication though so I rewrote the test.

My rewrite does *not* test for invalid connection parameters because it's
really hard without changing servicetest. I reckon it's something we can live
without though; every test will fail if we give a bad parameter due to
RequestConnection dying anyway...

I also removed the simple test for connecting with normal connection parameters
as connect/test-success.py does this for you already.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.