[Bug 47999] in-band and MUC bytestreams doesn't check if data is successfully sent

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=47999

--- Comment #1 from Will Thompson <will.thompson at collabora.co.uk> 2012-03-28 07:12:16 PDT ---
This branch
<http://cgit.collabora.com/git/user/wjt/telepathy-gabble/log/?h=47999-handle-ibb-errors>
makes the bytestream close up if a stanza gets dropped.

There's no test for this in the branch, because I know Jonny has been gutting
the tube tests of references to the old API and I don't want to conflict. I
tested this by making the test always send back errors for IBB IQs:

@@ -664,8 +664,7 @@ class BytestreamIBB(Bytestream):
             assert ibb_data['sid'] == self.stream_id

             # ack the IQ
-            result = make_result_iq(self.stream, ibb_event.stanza)
-            result.send()
+            send_error_reply(self.stream, ibb_event.stanza)

             if len(binary) >= size or size == 0:
                 received = True

Before this branch, tubes/accept-private-stream-tube.py (which tells Gabble to
send some data down the bytestream, waits for it to arrive, sends back a reply
over XMPP and sucks the reply out of Gabble) passes even with this change. With
this branch, this change breaks this and other tests, as you would expect.

This branch doesn't address MUCs.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.