[Bug 48084] Consumes 100% CPU when SSH-forwarded connection is refused

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=48084

Will Thompson <will.thompson at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://cgit.collabora.com/g
                   |                            |it/user/wjt/telepathy-idle/
                   |                            |log/?h=48084-eats-cpu-on-fa
                   |                            |iled-ssh-forward
           Keywords|                            |patch

--- Comment #1 from Will Thompson <will.thompson at collabora.co.uk> 2012-03-30 05:28:02 PDT ---
(In reply to comment #0)
> • IdleServerConnection should blow itself up if a write fails (or
> IdleConnection could do that);

I made IdleConnection blow up the connection on encountering
IdleServerConnection::status-changed.

> • IdleConnection should not try to requeue failed messages—it should just end
> the connection, one way or another.

I removed all the re-queueing logic; I think the
IdleServerConnection::status-changed handler will do the job for blowing the
connection away.

> • IdleServerConnection should end the connection if
> g_input_stream_read_finish() returns 0.

Yup, it now emits ::status-changed in this case.

2087 % git diff --stat master src
 src/idle-connection.c        |  154 ++++++++++-------------------------------
 src/idle-server-connection.c |   18 +++++-
 2 files changed, 55 insertions(+), 117 deletions(-)

Not bad.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.