[Bug 49335] rename UpdateCapabilities to SetCapabilities?

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=49335

--- Comment #4 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2012-05-01 06:23:38 PDT ---
(In reply to comment #2)
> Here is how UpdateCaps is meant to work, in Python-like pseudocode:
> 
>     class Connection:
>         handlers = {}

In Gabble this is self->priv->client_caps and self->priv->client_data_forms,
FYI.

The Gabble implementation is pretty confusing, because
gabble_caps_channel_manager_reset_capabilities() exists. It is in fact only
implemented by the media factory, where it sets "use Call" to FALSE.

This is a bug: if you update a non-Call client, Gabble stops using Call! That's
not right. The correct thing would be for GabbleConnection to maintain a set
containing the clients able to do Call, and use Call whenever that set is
non-empty.

As it happens, Mission Control (which does have a complete picture of
everything that's going on) does treat the method as though it had "set"
semantics. This avoids that bug, and is harmless in every case, except that of
a disappearing handler: the spec implies that Mission Control should call
UpdateCapabilities(["the.one.that.disappeared", [], []]) whenever a Handler
disappears, but it does not.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.